From 3542350909b1213240e5097a1793a7c0733f6196 Mon Sep 17 00:00:00 2001 From: Fabian Mastenbroek Date: Tue, 13 Dec 2022 23:59:47 +0000 Subject: fix(trace/wtf): Disable Parquet strict typing This change fixes an issue where some of the traces from the Workflow Trace Archive would fail to load with the trace format in OpenDC. This was caused by one of the fields being stored as a double, while the formats expects it to be a long. Parquet does not support unioning primitive types. Therefore, we have to disable strict type checking when reading the file. Furthermore, we need to support double entries for storing the workflow ids. --- .../src/main/kotlin/org/opendc/trace/wtf/WtfTraceFormat.kt | 2 +- .../kotlin/org/opendc/trace/wtf/parquet/TaskRecordMaterializer.kt | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) (limited to 'opendc-trace/opendc-trace-wtf/src/main') diff --git a/opendc-trace/opendc-trace-wtf/src/main/kotlin/org/opendc/trace/wtf/WtfTraceFormat.kt b/opendc-trace/opendc-trace-wtf/src/main/kotlin/org/opendc/trace/wtf/WtfTraceFormat.kt index bf834778..c25b512c 100644 --- a/opendc-trace/opendc-trace-wtf/src/main/kotlin/org/opendc/trace/wtf/WtfTraceFormat.kt +++ b/opendc-trace/opendc-trace-wtf/src/main/kotlin/org/opendc/trace/wtf/WtfTraceFormat.kt @@ -78,7 +78,7 @@ public class WtfTraceFormat : TraceFormat { override fun newReader(path: Path, table: String, projection: List?): TableReader { return when (table) { TABLE_TASKS -> { - val reader = LocalParquetReader(path.resolve("tasks/schema-1.0"), TaskReadSupport(projection)) + val reader = LocalParquetReader(path.resolve("tasks/schema-1.0"), TaskReadSupport(projection), strictTyping = false) WtfTaskTableReader(reader) } else -> throw IllegalArgumentException("Table $table not supported") diff --git a/opendc-trace/opendc-trace-wtf/src/main/kotlin/org/opendc/trace/wtf/parquet/TaskRecordMaterializer.kt b/opendc-trace/opendc-trace-wtf/src/main/kotlin/org/opendc/trace/wtf/parquet/TaskRecordMaterializer.kt index f188a3ff..055be0c3 100644 --- a/opendc-trace/opendc-trace-wtf/src/main/kotlin/org/opendc/trace/wtf/parquet/TaskRecordMaterializer.kt +++ b/opendc-trace/opendc-trace-wtf/src/main/kotlin/org/opendc/trace/wtf/parquet/TaskRecordMaterializer.kt @@ -30,6 +30,7 @@ import org.apache.parquet.schema.MessageType import java.time.Duration import java.time.Instant import kotlin.math.roundToInt +import kotlin.math.roundToLong /** * A [RecordMaterializer] for [Task] records. @@ -145,6 +146,10 @@ internal class TaskRecordMaterializer(schema: MessageType) : RecordMaterializer< override fun addLong(value: Long) { relations.add(value.toString()) } + + override fun addDouble(value: Double) { + relations.add(value.roundToLong().toString()) + } } private val listConverter = object : GroupConverter() { -- cgit v1.2.3