From 6bbfbd7aeb99475308a140222316f3e9006aeec3 Mon Sep 17 00:00:00 2001
From: Fabian Mastenbroek <mail.fabianm@gmail.com>
Date: Tue, 1 Nov 2022 10:38:26 +0100
Subject: refactor(compute/api): Do not suspend in compute API

This change updates the API interface of the OpenDC Compute service to
not suspend execution using Kotlin Coroutines.

The suspending modifiers were introduced in case the ComputeClient would
communicate with the service over a network connection. However, the main
use-case has been together with the ComputeService, where the suspending
modifiers only frustrate the user experience when writing experiments.

Furthermore, with the advent of Project Loom, it is not necessarily a
problem to block the (virtual) thread during network communications.
---
 .../org/opendc/compute/service/ComputeServiceTest.kt | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

(limited to 'opendc-compute/opendc-compute-service/src/test')

diff --git a/opendc-compute/opendc-compute-service/src/test/kotlin/org/opendc/compute/service/ComputeServiceTest.kt b/opendc-compute/opendc-compute-service/src/test/kotlin/org/opendc/compute/service/ComputeServiceTest.kt
index b5685aba..13b926e8 100644
--- a/opendc-compute/opendc-compute-service/src/test/kotlin/org/opendc/compute/service/ComputeServiceTest.kt
+++ b/opendc-compute/opendc-compute-service/src/test/kotlin/org/opendc/compute/service/ComputeServiceTest.kt
@@ -170,7 +170,7 @@ internal class ComputeServiceTest {
 
         server.start()
         delay(5L * 60 * 1000)
-        server.refresh()
+        server.reload()
         assertEquals(ServerState.TERMINATED, server.state)
     }
 
@@ -183,7 +183,7 @@ internal class ComputeServiceTest {
 
         server.start()
         delay(5L * 60 * 1000)
-        server.refresh()
+        server.reload()
         assertEquals(ServerState.TERMINATED, server.state)
     }
 
@@ -196,7 +196,7 @@ internal class ComputeServiceTest {
 
         server.start()
         delay(5L * 60 * 1000)
-        server.refresh()
+        server.reload()
         assertEquals(ServerState.TERMINATED, server.state)
     }
 
@@ -210,7 +210,7 @@ internal class ComputeServiceTest {
         server.start()
         server.stop()
         delay(5L * 60 * 1000)
-        server.refresh()
+        server.reload()
         assertEquals(ServerState.TERMINATED, server.state)
     }
 
@@ -231,7 +231,7 @@ internal class ComputeServiceTest {
 
         server.start()
         delay(10L * 60 * 1000)
-        server.refresh()
+        server.reload()
         assertEquals(ServerState.PROVISIONING, server.state)
 
         verify { host.canFit(server) }
@@ -262,7 +262,7 @@ internal class ComputeServiceTest {
         listeners.forEach { it.onStateChanged(host, HostState.UP) }
 
         delay(5L * 60 * 1000)
-        server.refresh()
+        server.reload()
         assertEquals(ServerState.PROVISIONING, server.state)
 
         verify { host.canFit(server) }
@@ -293,7 +293,7 @@ internal class ComputeServiceTest {
 
         server.start()
         delay(5L * 60 * 1000)
-        server.refresh()
+        server.reload()
         assertEquals(ServerState.PROVISIONING, server.state)
 
         verify(exactly = 0) { host.canFit(server) }
@@ -351,7 +351,7 @@ internal class ComputeServiceTest {
 
         listeners.forEach { it.onStateChanged(host, slot.captured, ServerState.RUNNING) }
 
-        server.refresh()
+        server.reload()
         assertEquals(ServerState.RUNNING, server.state)
 
         verify { watcher.onStateChanged(server, ServerState.RUNNING) }
@@ -359,7 +359,7 @@ internal class ComputeServiceTest {
         // Stop server
         listeners.forEach { it.onStateChanged(host, slot.captured, ServerState.TERMINATED) }
 
-        server.refresh()
+        server.reload()
         assertEquals(ServerState.TERMINATED, server.state)
 
         verify { watcher.onStateChanged(server, ServerState.TERMINATED) }
@@ -387,7 +387,7 @@ internal class ComputeServiceTest {
         server.start()
         delay(5L * 60 * 1000)
 
-        server.refresh()
+        server.reload()
         assertEquals(ServerState.PROVISIONING, server.state)
     }
 }
-- 
cgit v1.2.3